[Patch] Remove spec_decode.metrics patch
#1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiyuan
added
long-term-test
|
the pr number in commit msg seems wrong? pls update, and update commit msg completely, especially, note the existing or new added test |
The cuda hard code of |
shen-shanshan
force-pushed
the
patch
branch
2 times, most recently
from
73999f0 to
2e7dbc1
Compare
Yikun
added
ready-for-test
76 tasks
|
approve, good change. |
mengwei805
approved these changes
Jun 6, 2025
Signed-off-by: shen-shanshan <[email protected]>
|
@wangxiyuan The CI is finally passed and this PR can be merged. |
|
Thanks for the clean up |
Yikun
added
ready-for-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Remove
spec_decode.metricspatch as this has been resolved in vllm-project/vllm#16983 (include in vllmv0.9.0).Returns a CUDA event recording when the copy is complete --after modified--> Returns a device event (NPU Event for vllm-ascend) recording when the copy is complete.
Does this PR introduce any user-facing change?
How was this patch tested?