-
Notifications
You must be signed in to change notification settings - Fork 271
[FEAT] Terraform Quickstart Tutorials for Google GKE #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: falconlee236 <[email protected]>
Signed-off-by: falconlee236 <[email protected]>
production-stack with GKE Terraform integration is finished just now. I am curious about this project and all about vllm's projects. I have one more question about this project.
|
hey @falconlee236 Thanks so much for your contribution! This is awesome! will take a look soon. |
Signed-off-by: falconlee236 <[email protected]>
@YuhanLiu11 so
this comments is resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @falconlee236, thank you for submitting this PR. This is AWESOME!!! Could you add in the readme about some ways to customize the cluster (num of GPUs, GPU type, model type...)?
# This command provisions the GKE cluster, node pools, and deploys the vLLM stack in one step | ||
|
||
# Deploy just the GKE infrastructure | ||
make create-gke-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add in the Readme about choosing the GPUs I want to use in the beginning or the model I want to deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hanchenli
Add <🎮 GPU and Model Selection> Section in READEME.md
and add gpu variable to custom settings in gke-infrastructure/variables.tf
Hi @falconlee236, we are waiting on the AWS terraform tutorial to be finished. Do you want to talk about the blog some day? Are you in LMCache or vLLM channel? Can you send me your user name in the channel and I will send you a message to chat about it. |
Hi @Hanchenli My username in requested channel is Sangyun Lee. THX WIP) add settings about gpus and machine type of gcp until today. |
Signed-off-by: falconlee236 <[email protected]>
Signed-off-by: falconlee236 <[email protected]>
…ginning or the model I want to deploy Signed-off-by: falconlee236 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot for this great contribution!
Add complete guide for vLLM Production Stack deployment on GKE with Terraform
This PR adds comprehensive documentation for deploying a GPU-accelerated vLLM Production Stack on Google Kubernetes Engine (GKE) using Terraform. The implementation creates a production-ready infrastructure with specialized node pools for ML workloads and management services.
Key Features
Project Structure
Testing Done
facebook/opt-125m
modelConsiderations for Reviewers
FIX #172
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-s
when doinggit commit
[Bugfix]
,[Feat]
, and[CI]
.Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Feat]
for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]
for changes to thevllm_router
(e.g., routing algorithm, router observability, etc.).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-commit
to format your code. SeeREADME.md
for installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:
header which certifies agreement with the terms of the DCO.Using
-s
withgit commit
will automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.