Skip to content

Fix for issue #81 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Fix for issue #81 #84

merged 8 commits into from
Aug 20, 2024

Conversation

horheynm
Copy link
Contributor

@horheynm horheynm commented Aug 14, 2024

SUMMARY:
Fix for #81

steps:

  1. clone repo
  2. create and activate virtual eng
  3. pip3 install -e .[dev]
  4. change llm-compressor/examples/big_model_offloading/big_model_fp8.py line 34 from
    model_stub = "meta-llama/Meta-Llama-3-70B-Instruct"
    to
    model_stub = "microsoft/Phi-3-medium-128k-instruct"
  5. run the code with
# determine which layers to offload to cpu based on available resources
device_map = calculate_offload_device_map(
    model_stub, reserve_for_hessians=False, num_gpus=1, torch_dtype=torch.float16, trust_remote_code=True
)

the output config.json will get rid of line 201 from
"type": "longrope"
to
"type": "su"

TEST PLAN:
Run the code to completion, make sure that the issue does not come up.

@horheynm horheynm requested a review from Lin-K76 August 14, 2024 03:29
@horheynm horheynm changed the title fix Fix for issue #81 Aug 14, 2024
Copy link

@Lin-K76 Lin-K76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes, fixes error regarding the rope type and the configuration python files.

Copy link

@Lin-K76 Lin-K76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@horheynm horheynm self-assigned this Aug 14, 2024
Copy link

@Lin-K76 Lin-K76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example changes look good to me

@horheynm horheynm merged commit 0155a5c into main Aug 20, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants