-
Notifications
You must be signed in to change notification settings - Fork 193
[Testing] Set VLLM_WORKER_MULTIPROC_METHOD
for e2e testing
#1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a specific environment variable setting within an existing end-to-end test script. The purpose is to ensure proper behavior and compatibility for the vLLM
library's multiprocessing capabilities when running tests, likely addressing stability or execution issues in the test environment.
Highlights
- Testing Environment Configuration: Configured the
VLLM_WORKER_MULTIPROC_METHOD
environment variable to'spawn'
within the end-to-end test suite forvLLM
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a single line to set the VLLM_WORKER_MULTIPROC_METHOD
environment variable to spawn
in the test_vllm.py
file. This change likely addresses multiprocessing compatibility issues when running the vLLM tests. A minor suggestion is provided regarding the scope of setting environment variables in test files for improved maintainability.
VLLM_WORKER_MULTIPROC_METHOD
for e2e testing
…oject#1569) SUMMARY: - Set `VLLM_WORKER_MULTIPROC_METHOD` fo e2e vllm testing, as per vllm-project/vllm#14535 (comment) - With that, our e2e is green: https://github.com/neuralmagic/llm-compressor-testing/actions/runs/15739077015/job/44359835739
SUMMARY:
VLLM_WORKER_MULTIPROC_METHOD
fo e2e vllm testing, as perRuntimeError: Cannot re-initialize CUDA in forked subprocess
when initializing vLLM with tensor parallelism vllm#14535 (comment)