Skip to content

[Testing] Set VLLM_WORKER_MULTIPROC_METHOD for e2e testing #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Jun 18, 2025

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a specific environment variable setting within an existing end-to-end test script. The purpose is to ensure proper behavior and compatibility for the vLLM library's multiprocessing capabilities when running tests, likely addressing stability or execution issues in the test environment.

Highlights

  • Testing Environment Configuration: Configured the VLLM_WORKER_MULTIPROC_METHOD environment variable to 'spawn' within the end-to-end test suite for vLLM.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a single line to set the VLLM_WORKER_MULTIPROC_METHOD environment variable to spawn in the test_vllm.py file. This change likely addresses multiprocessing compatibility issues when running the vLLM tests. A minor suggestion is provided regarding the scope of setting environment variables in test files for improved maintainability.

@dsikka dsikka changed the title [Testing] Add env var [Testing] Set VLLM_WORKER_MULTIPROC_METHOD for e2e testing Jun 18, 2025
@dsikka dsikka marked this pull request as ready for review June 18, 2025 19:25
@dsikka dsikka enabled auto-merge (squash) June 18, 2025 19:35
@dsikka dsikka added the ready When a PR is ready for review label Jun 18, 2025
@dsikka dsikka merged commit a144d8b into main Jun 18, 2025
12 checks passed
@dsikka dsikka deleted the add_env_to_e2e branch June 18, 2025 19:35
aireilly pushed a commit to aireilly/llm-compressor that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants