Skip to content

[BugFix] Explicitly set gpu_memory_utilization #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025
Merged

[BugFix] Explicitly set gpu_memory_utilization #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7cd07e6
Explicitly set gpu_memory_utilization
rahul-tuli Jun 17, 2025
68ae878
Merge branch 'main' into fix-e2e-phi-3-test
dsikka Jun 17, 2025
fa30828
Refactor vLLM initialization to use kwargs pattern
rahul-tuli Jun 17, 2025
0b43ccb
Style
rahul-tuli Jun 17, 2025
f8a5a00
Merge branch 'main' into fix-e2e-phi-3-test
dsikka Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/e2e/vLLM/configs/kv_cache_phi3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ model: microsoft/Phi-3-mini-4k-instruct
recipe: tests/e2e/vLLM/recipes/kv_cache/default.yaml
dataset_id: HuggingFaceH4/ultrachat_200k
dataset_split: train_sft
scheme: kv_cache_default_phi3
scheme: kv_cache_default_phi3
gpu_memory_utilization: 0.8
13 changes: 10 additions & 3 deletions tests/e2e/vLLM/test_vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ def set_up(self, test_data_file: str):
self.save_compressed = eval_config.get("save_compressed", True)
self.num_calibration_samples = eval_config.get("num_calibration_samples", 256)
self.max_seq_length = eval_config.get("max_seq_length", 2048)
# GPU memory utilization - only set if explicitly provided in config
self.gpu_memory_utilization = eval_config.get("gpu_memory_utilization")

if not self.save_dir:
self.save_dir = self.model.split("/")[1] + f"-{self.scheme}"
Expand Down Expand Up @@ -195,11 +197,16 @@ def _run_vllm(self):
import torch

sampling_params = SamplingParams(temperature=0.80, top_p=0.95)
llm_kwargs = {"model": self.save_dir}

if "W4A16_2of4" in self.scheme:
# required by the kernel
llm = LLM(model=self.save_dir, dtype=torch.float16)
else:
llm = LLM(model=self.save_dir)
llm_kwargs["dtype"] = torch.float16

if self.gpu_memory_utilization is not None:
llm_kwargs["gpu_memory_utilization"] = self.gpu_memory_utilization

llm = LLM(**llm_kwargs)
outputs = llm.generate(self.prompts, sampling_params)
return outputs

Expand Down