[Tests] Fix Qwen2.5-VL-7B-Instruct Recipe
#1548
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue in the Qwen2.5-VL-7B-Instruct test recipes by updating the list of modules ignored during the GPTQ quantization process. The change ensures consistency with related updates and correctly excludes visual-related components from quantization in the specified test configurations.
Highlights
- Test Recipe Update: Updated the ignore list for GPTQ quantization in two Qwen2.5-VL test recipes (
INT8andw4a16_actorder) to exclude modules matching the regular expressionre:model.visual.*.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the ignore list for GPTQModifier in two E2E test recipes by adding the pattern "re:model.visual.*". This change is intended to fix the recipe for Qwen2.5-VL-7B-Instruct, likely by ensuring specific visual components are correctly excluded from quantization. The review includes suggestions to format the updated ignore lists as multi-line YAML block sequences, which can improve readability and maintainability, especially as these configuration lists tend to grow.
SUMMARY: - Update ignore list as per vllm-project#1545 - Note: We don't use an ignore list for for the Qwen2.5-VL FP8_Dynamic test?
SUMMARY: