[Example] [Bugfix] Fix Gemma3 Generation #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <[email protected]>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
brian-dellabetta
approved these changes
Jun 6, 2025
dsikka
pushed a commit
that referenced
this pull request
Jun 16, 2025
## Purpose ## * Fix gemma2 generation * See #1517 Signed-off-by: Kyle Sayers <[email protected]>
brian-dellabetta
pushed a commit
that referenced
this pull request
Jun 30, 2025
## Purpose ## * Fix generation for gemma models * See: #1517 ## Changes ## * Disable compilation for remaining gemma models --------- Signed-off-by: Kyle Sayers <[email protected]>
kylesayrs
added a commit
that referenced
this pull request
Jun 30, 2025
## Purpose ## * Fix generation for gemma models * See: #1517 ## Changes ## * Disable compilation for remaining gemma models --------- Signed-off-by: Kyle Sayers <[email protected]>
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ## * Fix Gemma3 example ## Background ## * Transformers `torch.compile`s the model function before running generation. However, some models fail to compile properly. As of the latest transformers version, Gemma3 is one of those models huggingface/transformers#38333 ## Changes ## * Disable compilation when generating with Gemma3 in example Signed-off-by: Kyle Sayers <[email protected]>
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ## * Fix gemma2 generation * See vllm-project#1517 Signed-off-by: Kyle Sayers <[email protected]>
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ## * Fix generation for gemma models * See: vllm-project#1517 ## Changes ## * Disable compilation for remaining gemma models --------- Signed-off-by: Kyle Sayers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Background
torch.compiles the model function before running generation. However, some models fail to compile properly. As of the latest transformers version, Gemma3 is one of those models MedGemma worked find prior to 4.52.3 release but now errors huggingface/transformers#38333Changes