Skip to content

[Tests] GPTQ Actorder Resolution Tests #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 30, 2025
Merged

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented May 22, 2025

Purpose

Changes

  • Remove TestQuantizationRegistered test, which is less necessary that it was before
  • Add test_actorder_resolution, which demonstrates and regression tests behavior related to resolving the actorder argument

Base automatically changed from kylesayrs/fix-default-actorder to main May 22, 2025 18:09
@kylesayrs kylesayrs marked this pull request as ready for review May 29, 2025 18:16
@kylesayrs kylesayrs added the ready When a PR is ready for review label May 29, 2025
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

Copy link
Collaborator

@shanjiaz shanjiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would appreciate if you could add a short docstring explaining what the test is about 🫡

@kylesayrs kylesayrs enabled auto-merge (squash) May 30, 2025 04:10
@kylesayrs kylesayrs merged commit 030a5be into main May 30, 2025
11 checks passed
@kylesayrs kylesayrs deleted the kylesayrs/actorder-test branch May 30, 2025 04:57
aireilly pushed a commit to aireilly/llm-compressor that referenced this pull request Jul 30, 2025
## Purpose ##
* Clarify behavior introduced by vllm-project#1453 

## Changes ##
* Remove `TestQuantizationRegistered` test, which is less necessary that
it was before
* Add `test_actorder_resolution`, which demonstrates and regression
tests behavior related to resolving the `actorder` argument

---------

Signed-off-by: Kyle Sayers <[email protected]>
Co-authored-by: Dipika Sikka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants