Skip to content

Remove duplicate model id var from awq example recipe #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

AndrewMead10
Copy link
Contributor

SUMMARY:
I noticed the MODELID var is declared twice in the AWQ example recipe, so i removed the second instance of it

TEST PLAN:
N/A

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@AndrewMead10 AndrewMead10 force-pushed the remove-duplicate-MODELID-var branch from 1d57186 to 8e8fb0d Compare May 22, 2025 16:17
@AndrewMead10
Copy link
Contributor Author

Cant edit the labels for some reason, but this is ready @dsikka @kylesayrs

Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@kylesayrs kylesayrs added the ready When a PR is ready for review label May 22, 2025
@dsikka dsikka merged commit 35855bd into vllm-project:main May 22, 2025
10 checks passed
aireilly pushed a commit to aireilly/llm-compressor that referenced this pull request Jul 30, 2025
)

SUMMARY:
I noticed the MODELID var is declared twice in the AWQ example recipe,
so i removed the second instance of it


TEST PLAN:
N/A

Signed-off-by: Andrew Mead <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants