[Bugfix][Tracing] Fix qwen2_5_vl #1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
brian-dellabetta
approved these changes
May 19, 2025
dsikka
approved these changes
May 19, 2025
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ## * Fix failing qwen_2_5_vl e2e test ## Changes ## * For recipes that run smoothquant before gptq, these recipes would populate `self.rope_deltas`. The existence of `self.rope_deltas` meant that subsequent tracing calls would not trigger [the condition to inject tracing metadata](https://github.com/vllm-project/llm-compressor/blob/main/src/llmcompressor/transformers/tracing/qwen2_5_vl.py#L406), leading to a tracing failure ## Testing ## * `CADENCE=weekly TEST_DATA_FILE=tests/lmeval/configs/vl_int8_w8a8_dynamic_per_token.yaml python3 -m pytest tests/lmeval/test_lmeval.py -sx` Signed-off-by: Kyle Sayers <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
self.rope_deltas. The existence ofself.rope_deltasmeant that subsequent tracing calls would not trigger the condition to inject tracing metadata, leading to a tracing failureTesting
CADENCE=weekly TEST_DATA_FILE=tests/lmeval/configs/vl_int8_w8a8_dynamic_per_token.yaml python3 -m pytest tests/lmeval/test_lmeval.py -sx