[Logging] Support logging once #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Kyle Sayers <[email protected]>
brian-dellabetta
previously approved these changes
May 14, 2025
Signed-off-by: Kyle Sayers <[email protected]>
markurtz
approved these changes
May 14, 2025
dsikka
pushed a commit
that referenced
this pull request
May 29, 2025
## Purpose ## * Test discrepancies between initialized parameters and values calculated by observers * Reveal potential issue with how qparams are initialized neuralmagic/compressed-tensors#308 * Add warning for when users attempt to quantize groups that aren't perfectly divisible ## Prerequisites ## * #1431 ## Changes ## * Added `test_observers_update` in `tests/llmcompressor/modifiers/calibration/test_observers.py` * Add a warning for attempts to quantize indivisible groups ``` Attempting to quantize a module weight whose columns (3420) are not divisible by group_size (128). This scheme is not supported by vLLM, please consider adjusting the group_size for modules with this number of columns ``` ## Testing ## * This test fails without CT changes, but succeeds with them --------- Signed-off-by: Kyle Sayers <[email protected]>
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ##
* Add ability to log messages only once
## Changes ##
* Add `support_log_once` filter
* Integrate `_initialize_metric_logging` function to reduce verbosity
## Testing ##
```python3
from llmcompressor.logger import logger
logger.bind(log_once=True).info("This will only log once")
# 2025-05-14T10:14:30.987512-0400 | <module> | INFO - This will only log once
logger.bind(log_once=True).info("This will only log once")
logger.bind(log_once=True).info("This will only log once")
logger.bind(log_once=True).info("This is unique")
# 2025-05-14T10:14:42.987610-0400 | <module> | INFO - This is unique
logger.bind(log_once=True).warning("This is unique")
# 2025-05-14T10:14:57.907901-0400 | <module> | WARNING - This is unique
```
---------
Signed-off-by: Kyle Sayers <[email protected]>
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ## * Test discrepancies between initialized parameters and values calculated by observers * Reveal potential issue with how qparams are initialized neuralmagic/compressed-tensors#308 * Add warning for when users attempt to quantize groups that aren't perfectly divisible ## Prerequisites ## * vllm-project#1431 ## Changes ## * Added `test_observers_update` in `tests/llmcompressor/modifiers/calibration/test_observers.py` * Add a warning for attempts to quantize indivisible groups ``` Attempting to quantize a module weight whose columns (3420) are not divisible by group_size (128). This scheme is not supported by vLLM, please consider adjusting the group_size for modules with this number of columns ``` ## Testing ## * This test fails without CT changes, but succeeds with them --------- Signed-off-by: Kyle Sayers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
support_log_oncefilter_initialize_metric_loggingfunction to reduce verbosityTesting