AWQ sanitize_kwargs minor cleanup #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-dellabetta
requested review from
dsikka,
kylesayrs,
rahul-tuli and
shanjiaz
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
kylesayrs
requested changes
May 5, 2025
kylesayrs
approved these changes
May 5, 2025
rahul-tuli
approved these changes
May 5, 2025
Signed-off-by: V-E-D <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
brian-dellabetta
force-pushed
the
bdellabe/awq-kwargs-bind
branch
from
67bae47 to
7ce1552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Using
inspect.bind_partialinside the AWQ_sanitize_kwargshelper does provide the robust support we were hoping. We still need to explicitly add None for the edge case, andbind_partialwill fail if the input kwargs have fields that are not in themodule.forwardsignature.So we have to stick with what we have. This PR just has some minor touch-ups and typehints, and removes the helpers that were only used by AWQ and not needed
Resolves #1385
Replaces #1386
TEST PLAN:
No net new src code, just minor cleanup and redundant code removal