Skip to content

[Bugfix] Disable generation of deepseek models with transformers>=4.48 #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

[Bugfix] Disable generation of deepseek models with transformers>=4.48 #1259

merged 1 commit into from
Mar 17, 2025

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Generation is broken on deepseek models due to a deprecation by transformers. This PR skips generation in that case

Related Issues

@vllm-project vllm-project deleted a comment from github-actions bot Mar 17, 2025
@dsikka dsikka added the ready When a PR is ready for review label Mar 17, 2025
@dsikka dsikka merged commit c6f28fb into main Mar 17, 2025
9 checks passed
@dsikka dsikka deleted the kylesayrs/patch-deepseek-generation branch March 17, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@dsikka dsikka dsikka approved these changes

Assignees
No one assigned
Labels
ready When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylesayrs @brian-dellabetta @dsikka