-
Notifications
You must be signed in to change notification settings - Fork 189
[Train] Training Pipeline #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: George Ohashi <[email protected]>
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Order of reviews: #1206 <-- Here #1207 #1209 #1212 #1214 SUMMARY: Rename data_args to dataset_args TEST PLAN: Pass tests FInd `data_args` using `grep` --------- Signed-off-by: George Ohashi <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
LGTM pending tests! |
…ot (#1212) Order of reviews: #1206 #1207 #1209 #1212 <-- Here #1214 SUMMARY: * Move the preprocessing and postprocessing logic out of `src/llmcompressor/transformers/finetune/text_generation.py` and into `src/llmcompressor/entrypoints/utils.py` TEST PLAN: Pass tests Signed-off-by: Brian Dellabetta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write a more descriptive PR description, summarizing changes and test steps.
The current description isn't very helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given one comment.
We've validated with our current examples:
- https://github.com/vllm-project/llm-compressor/tree/main/examples/trl_mixin
- https://github.com/vllm-project/llm-compressor/blob/main/examples/quantization_2of4_sparse_w4a16/llama7b_sparse_w4a16.py
run to completion, outputs make sense?
Order of reviews:
#1206
#1207
#1209
#1212
#1214 <-- Here
SUMMARY:
TEST PLAN: