Skip to content

Fix logging bug in oneshot.py #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix logging bug in oneshot.py #1213

merged 1 commit into from
Feb 28, 2025

Conversation

aman2304
Copy link
Contributor

SUMMARY:

Changed logger.waning to logger.warning in oneshot.py

TEST PLAN:
make test passes

@aman2304 aman2304 force-pushed the fix_oneshot_logging_bug_v1 branch from 259e78a to c8d37fa Compare February 28, 2025 17:18
@horheynm
Copy link
Contributor

Great catch thank you :)

@horheynm horheynm added the ready When a PR is ready for review label Feb 28, 2025
@dsikka dsikka enabled auto-merge (squash) February 28, 2025 21:25
@dsikka dsikka merged commit 5105475 into vllm-project:main Feb 28, 2025
7 checks passed
@brian-dellabetta
Copy link
Collaborator

@aman2304 appreciate the community contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsikka dsikka dsikka approved these changes

@horheynm horheynm horheynm approved these changes

Assignees
No one assigned
Labels
ready When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aman2304 @horheynm @brian-dellabetta @dsikka