-
Notifications
You must be signed in to change notification settings - Fork 193
[StageRunner] Stage Runner entrypoint and pipeline #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/llmcompressor/transformers/finetune/test_oneshot_and_finetune.py
Outdated
Show resolved
Hide resolved
tests/llmcompressor/transformers/sparsification/test_compress_tensor_utils.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I much prefer this interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few clarifying questions but i think is ready to roll!
tests/llmcompressor/transformers/sparsification/test_compress_tensor_utils.py
Show resolved
Hide resolved
bbdd8c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently failing the multi-stage example: llama7b_sparse_w4a16.py
under llm-compressor/examples/quantization_2of4_sparse_w4a16
- seems to get get past the sparsity stage and then fails during finetune.
@kylesayrs can you take a look?
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
SUMMARY:
Remove
from_args
and reorg logic in Oneshot. Previously used to be compatible withclass StageRunner
, which is removed.Remove
StageRunType
and its logic from StageRunner and related files.Remove
class StageRuneer
and its file.Remove stage runner logic from
transformers/text_geneneration.py
Remove
tests/llmcompressor/entrypoints/test_oneshot.py
, which is a test forOneshot.from_args
, which is removed.Remove
tests/llmcompressor/recipe/test_stage.py
which is a test to select the stage and run_type.Add logic in
train
to return a PretrainedModel, and also to change output_dir ifstage
is passed in tooneshot
ortrain
. If stage is passed in the new directory changes from./out
->./out/{stage}
.Add
stage
in RecipeArgumentsModify saving logic in trainer. Use
self.trainer.save
instead ofpost_process
save.post_process
will still be called, but will only reset session.Modify logic in
post_process
to save + reset or only reset, if no model_args or output_dir is passed in. (need model_args for model, output_dir for save dir)TEST PLAN:
Pass tests
Check
examples/quantization_2of4_sparse_w4a16/llama7b_sparse_w4a16.py
runs and generates the same output as mainSCRIPT: