Skip to content

Remove CLI #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2025
Merged

Remove CLI #1144

merged 4 commits into from
Feb 20, 2025

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Feb 13, 2025

Summary

  • Remove cli support

Testing:

  • Need to make sure everything is removed

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

horheynm
horheynm reviewed Feb 13, 2025
View reviewed changes
@horheynm horheynm mentioned this pull request Feb 19, 2025
Closed
@horheynm horheynm marked this pull request as ready for review February 20, 2025 15:25
kylesayrs
kylesayrs approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd suggest leaving some deprecation warnings, but in this case I think these endpoints are really unused and save to remove

@dsikka dsikka added the ready When a PR is ready for review label Feb 20, 2025
@dsikka dsikka enabled auto-merge (squash) February 20, 2025 16:28
@dsikka dsikka merged commit ff007b6 into main Feb 20, 2025
7 checks passed
@dsikka dsikka deleted the rm_cli branch February 20, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horheynm horheynm horheynm left review comments

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@kylesayrs kylesayrs kylesayrs approved these changes

Assignees
No one assigned
Labels
ready When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsikka @brian-dellabetta @kylesayrs @horheynm