Skip to content

patch_tied_tensors_bug: support malformed model definitions #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2025
Merged

patch_tied_tensors_bug: support malformed model definitions #1014

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
148e617
account for models which improperly do not override the abstract methods
kylesayrs Dec 27, 2024
9781d78
Merge branch 'main' into kylesayrs/patch-mal-models
kylesayrs Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/llmcompressor/transformers/sparsification/compressed_tensors_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,10 @@ def patch_tied_tensors_bug(model: torch.nn.Module):
input_embed = model.get_input_embeddings()
output_embed = model.get_output_embeddings()

if input_embed is None or output_embed is None:
# some models fail to properly override the abstract methods
return

if storage_ptr(input_embed.weight) == storage_ptr(output_embed.weight):
for module in (input_embed, output_embed):
if not is_module_offloaded(module):
Expand Down
Loading