math: fix vec2,3,4 project not using the right formulas #25813
Conversation
… functions added documentation for some methods and fixed project and abs vec probably a lot more work
Refactor project function to handle zero vector case and calculate projection properly
spytheman
left a comment
spytheman
left a comment
There was a problem hiding this comment.
Please add tests for the changed .project methods, to prevent future regressions.
Added tests for vec3 projection functionality, including basic projection and projection onto a zero vector.
|
You have to also run |
|
Lets wait for my test(s). |
|
My research. @spytheman Yes, the current implementation is incorrect. I've checked everything and I'm not approving the merge. I have several sources to prove that his implementation is not correct. @gw-dev101 Thanks for working on this. I appreciate it. You got confused in the details and parameters, fix the code, comments, tests and come back with new commit(s). |
|
That's the main issue with trying to make a pr at 2am |
|
Not a waste of time - it brought an issue up that not many were even thinking about. You also don't need to make a second PR - just push modifications to this one. |
5 participants
addresses #25811 by replacing some of the formulas with the correct ones
(the old one only worked when both vectors had the same magnitude)
i think there is still some more work to be done on the module before it is satifactory