extraNetworks.js fix for networks menu with process caption gallery tabs #4149
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More robust code by adding a simple check to ensure that searchTextarea is not null, added a check for debugging if it ever fails again Fixed getENActiveTab, expression tabName in ['process', 'caption', 'gallery'] will always solve as false, making network menus inoperable when in either of these tabs.
Additional fix for lastTab updating with an empty string. This could cause the issue to reemerge if one of the three tabs was the initial tab upon startup.
|
Additional fix for lastTab updating with an empty string. This could cause the issue to reemerge if one of the three tabs was the initial tab upon startup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More robust code by adding a simple check to ensure that searchTextarea is not null, added a check for debugging if it ever fails again
Fixed getENActiveTab, expression tabName in ['process', 'caption', 'gallery'] will always solve as false, making network menus inoperable when in either of these tabs.
I think it's a simple oversight as in the original UI it's not possible to open networks menu in those tabs.