Klaus update submodules #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from viur-framework/viur-base.
Update viur-base
* Update viur-core to the last commit before the server core is moved to a core directory. * Update ignite to the last version before 4.0.0
The TreeType Class is removed from the core (viur.core.prototypes.tree). So I removed it from the file module and replaced it with the string "node" as suggested by @phorward.
phorward
approved these changes
Mar 14, 2021
There was a problem hiding this comment.
Hello @klaus-thorres thank you for your pull request. This looks all good for me. Yes, viur-core now has a subfolder, because it will soon be turned into a PyPI package. Therefore, huger changes in the viur-base repo will come. Nevertheless, your pull request is very helpful for the current setup. Keep up the good work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys :)
I updated the viur-base submodules. This includes: