Skip to content

fix(coverage): ignore SCSS in browser mode #8161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2025

Conversation

sheremet-va
Copy link
Member

Description

Fixes #8154

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jun 14, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit e9bfa66
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/684d6be8cc31a000087f65a7
😎 Deploy Preview https://deploy-preview-8161--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! I wasn't aware of isCSSRequest. 💯

@sheremet-va sheremet-va merged commit 0c3be6f into vitest-dev:main Jun 14, 2025
15 checks passed
@sheremet-va sheremet-va deleted the fix/coverage-check-css branch June 14, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vitest/coverage-istanbul breaks when running tests in @vitest/browser with scss
2 participants