-
-
Couldn't load subscription status.
- Fork 7.4k
fix(css): empty CSS entry points should generate CSS files, not JS files #20518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sapphi-red
merged 14 commits into
main
from
copilot/fix-eca397cc-5c53-474f-a6b2-9c3f45b7fd8d
Aug 5, 2025
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8eecbbd
Initial plan
Copilot b931d4a
Initial analysis and reproduction of empty CSS issue
Copilot d27fcfe
Fix empty CSS rollup input generating empty JS output
Copilot 658bb82
Move empty CSS test from unit test to E2E test in playground
Copilot 5a1f0ad
Address review feedback: move test and improve chunkCSS logic
Copilot dce1179
fix: resolve TypeScript error in CSS plugin chunkCSS type narrowing
Copilot 9f18c47
chore: update
sapphi-red 8efb35b
chore: update
sapphi-red 9f97dcb
chore: update
sapphi-red 917a0b2
test(css): use findAssetFile instead of manifest to validate empty CS…
Copilot 6498e62
Remove unused readManifest import and manifest config
Copilot 24b0f34
test: return `undefined` from `findAssetFile` to differentiate with e…
sapphi-red a9b108a
test: add js file check
sapphi-red 4205dbd
test: a bit more fixes
sapphi-red File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.