Skip to content

fix: backward compat for internal plugin transform calls #19878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix: backward compat for internal plugin transform calls #19878

merged 1 commit into from
Apr 17, 2025
+18 −4

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Apr 17, 2025 •
edited
Loading

Description

Adding a similar backward compat as #19586 (comment) for vite:css-post (unocss unocss/unocss#4597) and vite:json (unplugin-vue-i18n intlify/bundle-tools#483).

I verified the repro in intlify/bundle-tools#483 is fixed https://stackblitz.com/edit/vitejs-vite-cddhcqn4?file=package.json

@hi-ogawa hi-ogawa marked this pull request as ready for review April 17, 2025 00:24
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 17, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/vite@19878

commit: 9455e8b

@sapphi-red
Copy link
Member

/ecosystem-ci run

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Apr 17, 2025
@vite-ecosystem-ci

This comment was marked as outdated.

Sign in to view
@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 9455e8b: Open

suite result latest scheduled
nuxt ✅ success ❌ failure
vike ✅ success ❌ failure
laravel ❌ failure ❌ failure

✅ astro, histoire, previewjs, qwik, ladle, vite-plugin-pwa, marko, quasar, unocss, storybook, rakkas, vite-setup-catalogue, vite-plugin-cloudflare, react-router, vite-plugin-react, vite-plugin-react-swc, analogjs, vite-environment-examples, sveltekit, vite-plugin-vue, vitest, waku, vite-plugin-svelte, vuepress, vitepress

@sapphi-red sapphi-red changed the title fix: backward compat for builtin plugin transform calls fix: backward compat for internal plugin transform calls Apr 17, 2025
@sapphi-red sapphi-red merged commit a152b7c into vitejs:main Apr 17, 2025
23 checks passed
@sapphi-red sapphi-red mentioned this pull request Apr 17, 2025
Merged
This was referenced Apr 17, 2025
Closed
Closed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 17, 2025
@renovate
Update dependency vite to v6.3.1
e879be1 
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | vite    | 6.2.1 | 6.3.1 |


## [v6.3.1](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small631-2025-04-17-small)

-   fix: avoid using `Promise.allSettled` in preload function ([#19805](vitejs/vite#19805)) ([35c7f35](vitejs/vite@35c7f35)), closes [#19805](vitejs/vite#19805)
-   fix: backward compat for internal plugin `transform` calls ([#19878](vitejs/vite#19878)) ([a152b7c](vitejs/vite@a152b7c)), closes [#19878](vitejs/vite#19878)


## [v6.3.0](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#630-2025-04-16)

-   fix(hmr): avoid infinite loop happening with `hot.invalidate` in circular deps ([#19870](vitejs/vite#19870)) ([d4ee5e8](vitejs/vite@d4ee5e8)), closes [#19870](vitejs/vite#19870)
-   fix(preview): use host url to open browser ([#19836](vitejs/vite#19836)) ([5003434](vitejs/vite@5003434)), closes [#19836](vitejs/vite#19836)


## [v6.2.6](https://github.com/vitejs/vite/releases/tag/v6.2.6)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.6/packages/vite/CHANGELOG.md) for details.


## [v6.2.5](https://github.com/vitejs/vite/releases/tag/v6.2.5)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.5/packages/vite/CHANGELOG.md) for details.


## [v6.2.4](https://github.com/vitejs/vite/releases/tag/v6.2.4)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.4/packages/vite/CHANGELOG.md) for details.


## [v6.2.3](https://github.com/vitejs/vite/releases/tag/v6.2.3)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.3/packages/vite/CHANGELOG.md) for details.


## [v6.2.2](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small622-2025-03-14-small)

-   fix: await client buildStart on top level buildStart ([#19624](vitejs/vite#19624)) ([b31faab](vitejs/vite@b31faab)), closes [#19624](vitejs/vite#19624)
-   fix(css): inline css correctly for double quote use strict ([#19590](vitejs/vite#19590)) ([d0aa833](vitejs/vite@d0aa833)), closes [#19590](vitejs/vite#19590)
-   fix(deps): update all non-major dependencies ([#19613](vitejs/vite#19613)) ([363d691](vitejs/vite@363d691)), closes [#19613](vitejs/vite#19613)
-   fix(indexHtml): ensure correct URL when querying module graph ([#19601](vitejs/vite#19601)) ([dc5395a](vitejs/vite@dc5395a)), closes [#19601](vitejs/vite#19601)
-   fix(preview): use preview https config, not server ([#19633](vitejs/vite#19633)) ([98b3160](vitejs/vite@98b3160)), closes [#19633](vitejs/vite#19633)
-   fix(ssr): use optional chaining to prevent "undefined is not an object" happening in \`ssrRewriteStac ([4309755](vitejs/vite@4309755)), closes [#19612](vitejs/vite#19612)
-   feat: show friendly error for malformed `base` ([#19616](vitejs/vite#19616)) ([2476391](vitejs/vite@2476391)), closes [#19616](vitejs/vite#19616)
-   feat(worker): show asset filename conflict warning ([#19591](vitejs/vite#19591)) ([367d968](vitejs/vite@367d968)), closes [#19591](vitejs/vite#19591)
-   chore: extend commit hash correctly when ambigious with a non-commit object ([#19600](vitejs/vite#19600)) ([89a6287](vitejs/vite@89a6287)), closes [#19600](vitejs/vite#19600)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 17, 2025
@renovate
Update dependency vite to v6.3.1
582a03a 
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | vite    | 6.2.1 | 6.3.1 |


## [v6.3.1](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small631-2025-04-17-small)

-   fix: avoid using `Promise.allSettled` in preload function ([#19805](vitejs/vite#19805)) ([35c7f35](vitejs/vite@35c7f35)), closes [#19805](vitejs/vite#19805)
-   fix: backward compat for internal plugin `transform` calls ([#19878](vitejs/vite#19878)) ([a152b7c](vitejs/vite@a152b7c)), closes [#19878](vitejs/vite#19878)


## [v6.3.0](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#630-2025-04-16)

-   fix(hmr): avoid infinite loop happening with `hot.invalidate` in circular deps ([#19870](vitejs/vite#19870)) ([d4ee5e8](vitejs/vite@d4ee5e8)), closes [#19870](vitejs/vite#19870)
-   fix(preview): use host url to open browser ([#19836](vitejs/vite#19836)) ([5003434](vitejs/vite@5003434)), closes [#19836](vitejs/vite#19836)


## [v6.2.6](https://github.com/vitejs/vite/releases/tag/v6.2.6)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.6/packages/vite/CHANGELOG.md) for details.


## [v6.2.5](https://github.com/vitejs/vite/releases/tag/v6.2.5)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.5/packages/vite/CHANGELOG.md) for details.


## [v6.2.4](https://github.com/vitejs/vite/releases/tag/v6.2.4)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.4/packages/vite/CHANGELOG.md) for details.


## [v6.2.3](https://github.com/vitejs/vite/releases/tag/v6.2.3)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.3/packages/vite/CHANGELOG.md) for details.


## [v6.2.2](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small622-2025-03-14-small)

-   fix: await client buildStart on top level buildStart ([#19624](vitejs/vite#19624)) ([b31faab](vitejs/vite@b31faab)), closes [#19624](vitejs/vite#19624)
-   fix(css): inline css correctly for double quote use strict ([#19590](vitejs/vite#19590)) ([d0aa833](vitejs/vite@d0aa833)), closes [#19590](vitejs/vite#19590)
-   fix(deps): update all non-major dependencies ([#19613](vitejs/vite#19613)) ([363d691](vitejs/vite@363d691)), closes [#19613](vitejs/vite#19613)
-   fix(indexHtml): ensure correct URL when querying module graph ([#19601](vitejs/vite#19601)) ([dc5395a](vitejs/vite@dc5395a)), closes [#19601](vitejs/vite#19601)
-   fix(preview): use preview https config, not server ([#19633](vitejs/vite#19633)) ([98b3160](vitejs/vite@98b3160)), closes [#19633](vitejs/vite#19633)
-   fix(ssr): use optional chaining to prevent "undefined is not an object" happening in \`ssrRewriteStac ([4309755](vitejs/vite@4309755)), closes [#19612](vitejs/vite#19612)
-   feat: show friendly error for malformed `base` ([#19616](vitejs/vite#19616)) ([2476391](vitejs/vite@2476391)), closes [#19616](vitejs/vite#19616)
-   feat(worker): show asset filename conflict warning ([#19591](vitejs/vite#19591)) ([367d968](vitejs/vite@367d968)), closes [#19591](vitejs/vite#19591)
-   chore: extend commit hash correctly when ambigious with a non-commit object ([#19600](vitejs/vite#19600)) ([89a6287](vitejs/vite@89a6287)), closes [#19600](vitejs/vite#19600)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 19, 2025
@renovate
Update dependency vite to v6.3.2
b254238 
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | vite    | 6.2.1 | 6.3.2 |


## [v6.3.2](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small632-2025-04-18-small)

-   fix: match default asserts case insensitive ([#19852](vitejs/vite#19852)) ([cbdab1d](vitejs/vite@cbdab1d)), closes [#19852](vitejs/vite#19852)
-   fix: open first url if host does not match any urls ([#19886](vitejs/vite#19886)) ([6abbdce](vitejs/vite@6abbdce)), closes [#19886](vitejs/vite#19886)
-   fix(css): respect `css.lightningcss` option in css minification process ([#19879](vitejs/vite#19879)) ([b5055e0](vitejs/vite@b5055e0)), closes [#19879](vitejs/vite#19879)
-   fix(deps): update all non-major dependencies ([#19698](vitejs/vite#19698)) ([bab4cb9](vitejs/vite@bab4cb9)), closes [#19698](vitejs/vite#19698)
-   feat(css): improve lightningcss messages ([#19880](vitejs/vite#19880)) ([c713f79](vitejs/vite@c713f79)), closes [#19880](vitejs/vite#19880)


## [v6.3.1](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small631-2025-04-17-small)

-   fix: avoid using `Promise.allSettled` in preload function ([#19805](vitejs/vite#19805)) ([35c7f35](vitejs/vite@35c7f35)), closes [#19805](vitejs/vite#19805)
-   fix: backward compat for internal plugin `transform` calls ([#19878](vitejs/vite#19878)) ([a152b7c](vitejs/vite@a152b7c)), closes [#19878](vitejs/vite#19878)


## [v6.3.0](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#630-2025-04-16)

-   fix(hmr): avoid infinite loop happening with `hot.invalidate` in circular deps ([#19870](vitejs/vite#19870)) ([d4ee5e8](vitejs/vite@d4ee5e8)), closes [#19870](vitejs/vite#19870)
-   fix(preview): use host url to open browser ([#19836](vitejs/vite#19836)) ([5003434](vitejs/vite@5003434)), closes [#19836](vitejs/vite#19836)


## [v6.2.6](https://github.com/vitejs/vite/releases/tag/v6.2.6)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.6/packages/vite/CHANGELOG.md) for details.


## [v6.2.5](https://github.com/vitejs/vite/releases/tag/v6.2.5)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.5/packages/vite/CHANGELOG.md) for details.


## [v6.2.4](https://github.com/vitejs/vite/releases/tag/v6.2.4)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.4/packages/vite/CHANGELOG.md) for details.


## [v6.2.3](https://github.com/vitejs/vite/releases/tag/v6.2.3)

Please refer to [CHANGELOG.md](https://github.com/vitejs/vite/blob/v6.2.3/packages/vite/CHANGELOG.md) for details.


## [v6.2.2](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small622-2025-03-14-small)

-   fix: await client buildStart on top level buildStart ([#19624](vitejs/vite#19624)) ([b31faab](vitejs/vite@b31faab)), closes [#19624](vitejs/vite#19624)
-   fix(css): inline css correctly for double quote use strict ([#19590](vitejs/vite#19590)) ([d0aa833](vitejs/vite@d0aa833)), closes [#19590](vitejs/vite#19590)
-   fix(deps): update all non-major dependencies ([#19613](vitejs/vite#19613)) ([363d691](vitejs/vite@363d691)), closes [#19613](vitejs/vite#19613)
-   fix(indexHtml): ensure correct URL when querying module graph ([#19601](vitejs/vite#19601)) ([dc5395a](vitejs/vite@dc5395a)), closes [#19601](vitejs/vite#19601)
-   fix(preview): use preview https config, not server ([#19633](vitejs/vite#19633)) ([98b3160](vitejs/vite@98b3160)), closes [#19633](vitejs/vite#19633)
-   fix(ssr): use optional chaining to prevent "undefined is not an object" happening in \`ssrRewriteStac ([4309755](vitejs/vite@4309755)), closes [#19612](vitejs/vite#19612)
-   feat: show friendly error for malformed `base` ([#19616](vitejs/vite#19616)) ([2476391](vitejs/vite@2476391)), closes [#19616](vitejs/vite#19616)
-   feat(worker): show asset filename conflict warning ([#19591](vitejs/vite#19591)) ([367d968](vitejs/vite@367d968)), closes [#19591](vitejs/vite#19591)
-   chore: extend commit hash correctly when ambigious with a non-commit object ([#19600](vitejs/vite#19600)) ([89a6287](vitejs/vite@89a6287)), closes [#19600](vitejs/vite#19600)
@sapphi-red sapphi-red mentioned this pull request May 5, 2025
Merged
sapphi-red added a commit to vitejs/rolldown-vite that referenced this pull request May 17, 2025
@sapphi-red
fix: apply filter for css-post plugin and json plugin
b04fee7 
this was not working because of vitejs#19586 (comment) and vitejs#19878
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
@hi-ogawa @moonlitusun
fix: backward compat for internal plugin transform calls (vitejs#19878
2874797 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release trigger: preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

orgTransform.apply is not a function
2 participants
@hi-ogawa @sapphi-red