Skip to content

refactor: remove isBuild check from preAliasPlugin #19587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

refactor: remove isBuild check from preAliasPlugin #19587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions packages/vite/src/node/external.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,24 +32,6 @@ export function shouldExternalize(
return isExternal(id, importer)
}

const isConfiguredAsExternalCache = new WeakMap<
Environment,
(id: string, importer?: string) => boolean
>()

export function isConfiguredAsExternal(
environment: Environment,
id: string,
importer?: string,
): boolean {
let isExternal = isConfiguredAsExternalCache.get(environment)
if (!isExternal) {
isExternal = createIsConfiguredAsExternal(environment)
isConfiguredAsExternalCache.set(environment, isExternal)
}
return isExternal(id, importer)
}

export function createIsConfiguredAsExternal(
environment: PartialEnvironment,
): (id: string, importer?: string) => boolean {
Expand Down
7 changes: 0 additions & 7 deletions packages/vite/src/node/plugins/preAlias.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import type {
ResolvedConfig,
} from '..'
import type { Plugin } from '../plugin'
import { isConfiguredAsExternal } from '../external'
import {
bareImportRE,
isInNodeModules,
Expand All @@ -22,7 +21,6 @@ import { tryOptimizedResolve } from './resolve'
*/
export function preAliasPlugin(config: ResolvedConfig): Plugin {
const findPatterns = getAliasPatterns(config.resolve.alias)
const isBuild = config.command === 'build'
return {
name: 'vite:pre-alias',
async resolveId(id, importer, options) {
Expand Down Expand Up @@ -65,11 +63,6 @@ export function preAliasPlugin(config: ResolvedConfig): Plugin {
(isInNodeModules(resolvedId) ||
optimizeDeps.include?.includes(id)) &&
isOptimizable(resolvedId, optimizeDeps) &&
!(
isBuild &&
ssr &&
isConfiguredAsExternal(environment, id, importer)
) &&
(!ssr || optimizeAliasReplacementForSSR(resolvedId, optimizeDeps))
) {
// aliased dep has not yet been optimized
Expand Down