-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
feat(client): ping from SharedWorker #19057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): ping from SharedWorker #19057
Conversation
I noticed that Safari 7-15 does not support Shared Worker 😢 I assumed that it's globally available... |
/ecosystem-ci run |
commit: |
📝 Ran ecosystem CI on
✅ analogjs, histoire, ladle, laravel, qwik, vite-plugin-react, storybook, vite-plugin-vue, marko, sveltekit, vitepress, waku, quasar, vite-plugin-cloudflare, vite-setup-catalogue, nuxt, vite-plugin-svelte, unocss, vite-plugin-pwa, rakkas, vite-plugin-rsc, react-router, one, vuepress |
Description
No more log spamming with
WebSocket connection to * failed:
🙂I came up with an idea to eliminate the WebSocket pinging in the network tab and the connection error logs and this PR implements that idea.
This PR moves the pinging logic to a shared worker. This makes the connection error log and the network request to be output in a different location (at least for Chrome, haven't checked with other browsers). Except for that, everything should work the same.
Since the error log and the network requests won't be output in the (main) devtools, I guess this would reduce the memory consumption.
closes #16361