fix: ensure req.url matches moduleByEtag URL to avoid incorrect 304 r… #17997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, remix, storybook, sveltekit, unocss, vike, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress |
patak-dev
previously approved these changes
Sep 9, 2024
Member
patak-dev
left a comment
patak-dev
left a comment
There was a problem hiding this comment.
The detailed explanation in the issue is fantastic! Thanks for the fix and sorry for the glitch.
patak-dev
reviewed
Sep 9, 2024
patak-dev
reviewed
Sep 9, 2024
patak-dev
reviewed
Sep 9, 2024
patak-dev
approved these changes
Sep 9, 2024
patak-dev
pushed a commit
that referenced
this pull request
Sep 11, 2024
patak-dev
added a commit
that referenced
this pull request
Sep 11, 2024
…d incorrect 304 (#18078) Co-authored-by: coderwei <[email protected]>
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #17987