Skip to content

Conversation

@sapphi-red
Copy link
Member

Description

This PR aims to fix these flaky fails:

FAIL  playground/html/__tests__/html.spec.ts > invalid > should reload when fixed
TimeoutError: page.waitForSelector: Timeout 30000ms exceeded.

(All links includes the same error message.)

I'm not sure if it will actually fix the fail because I wasn't able to reproduce it locally though.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Aug 28, 2024
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Member Author

The CI passed five times a row. Probably fixed the flaky fail.

@patak-dev patak-dev merged commit 8ce8683 into vitejs:main Aug 28, 2024
@sapphi-red sapphi-red deleted the test/fix-flaky-should-reload-test branch August 28, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority) test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants