fix(css): handle url replacing when preprocessing with lightningcss #17364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
feat: css
p3-minor-bug
|
|
btea
reviewed
Jun 1, 2024
| const replaceUrl = await urlReplacer(dep.url, id) | ||
| css = css.replace(dep.placeholder, () => replaceUrl) | ||
| } else { | ||
| css = css.replace(dep.placeholder, () => dep.url) |
Contributor
There was a problem hiding this comment.
Why does the replace function use a function as the second parameter? This seems unnecessary. 🤔
Contributor
There was a problem hiding this comment.
Thanks for the link.
This seems a bit weird, it's the first time I've come across this.
Contributor
There was a problem hiding this comment.
patak-dev
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
preprocessCSSwith lightningcss,urlReplaceris undefined, so the css urls should be left intact but we didn't replace the placeholder back to original in this case.(from astro) closes withastro/astro#11060 (comment)