This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Network: Adjust documentation for arrows.middle.scaleFactor #3488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addendum to visjs#3474. Updated the documentation, so that users can know about flipping the middle arrow with a negative scale factor.
mbroad
reviewed
Sep 27, 2017
docs/network/edges.html
Outdated
| <td>Exactly the same as the to object but with an arrowhead in the center of the edge.</td> | ||
| <td>In general, the same as the to object but with an arrowhead in the center of the edge. | ||
| The only difference is that the direction of the arrow can be flipped by using a negative | ||
| value for <code>arrows.middle.scaleFactor</code>.</td> |
There was a problem hiding this comment.
Consider dropping superfluous wording and wrapping the word to in single quotes:
<td>Similar to the 'to' object, but with an arrowhead in the center of the edge. The direction of the arrow can be flipped by using a negative value for <code>arrows.middle.scaleFactor</code>.</td>
|
One nit. But this is fine as is if you don't like my suggestion. |
mbroad
approved these changes
Sep 27, 2017
|
I'm going with your suggestion; documentation should be as clear and concise as feasible. |
mbroad
approved these changes
Sep 27, 2017
yotamberk
approved these changes
Sep 29, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Network: Adjust documentation for arrows.middle.scaleFactor Addendum to visjs#3474. Updated the documentation, so that users can know about flipping the middle arrow with a negative scale factor. * Adjusted text for review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #3474.
Updated the documentation, so that users can know about flipping the middle arrow with a negative scale factor.