Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Enable 'eslint' #3230

Merged
merged 8 commits into from
Jul 16, 2017
Merged

Enable 'eslint' #3230

merged 8 commits into from
Jul 16, 2017

Conversation

wimrijnders
Copy link
Contributor

This enables linting for vis.js.

  • Replaces the babel-eslint (has issues) with gulp-eslint
  • Has been added to package.json, so it should be automatically installed.
  • Linting has intentionally not been added yet to the default task; there are simply too many errors at the moment to make this comfortable
  • Can be run as follows:
 > gulp lint            # Run over all of vis.js
 > gulp lint-graph3d
 > gulp lint-network
 > gulp lint-timeline

The linting has been run over Graph3d, results are added here for reference of what changes this brings.

On the whole, I'm pretty happy with eslint; I hope it comes in regular use.

@wimrijnders
Copy link
Contributor Author

wimrijnders commented Jul 3, 2017

Removing command-line option -g in .travis.yml seems to fix the travis build problem. I hope this is OK.

@yotamberk yotamberk merged commit 221757c into visjs:develop Jul 16, 2017
@wimrijnders wimrijnders deleted the enableESLint branch July 17, 2017 04:28
primozs pushed a commit to primozs/vis that referenced this pull request Jan 3, 2019
* First working version of eslint enabled with gulp

* Tryout of eslint with graph3d files

* Cleanup of gulp and eslint files.

* Completed test by linting graph3d

* Disable travis linting for now

* Remove global cmd param from .travis.yml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants