This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Fix option handling label selection of edges #3116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimrijnders
changed the title
yotamberk
approved these changes
May 31, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Fix selection nodes so that option selectConnectedEdges works as expected * Using instance var select instead of local var in Edge.drawLabel()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix for #2990.
Option
interaction.selectConnectedEdgeswas not working as expected. Adjusted selection determination inEdge.drawlabel()to fix this. The working of all options underinteractionexcepttoolTipDelayhave been verified to work correctly.Update: This PR needs expansion. There are more options related to labels which need to be considered: notably,
edge.chosen.labelandedge.labelHighlightBold.