self reference edge should now appear in all cases

[eymiha]

fixes #2591

some calls to extract circle data were passing invalid arguments.

[Tooa]

This does not work with the example provided in #2591 here. Apply your fix and you will see that the self-reference edges disappear when moving the nodes.

[eymiha]

On a Mac... npm run watch then launch Chrome (mine is Version 55.0.2883.95 (64-bit)) and open examples/network/basic_usage.html...

The circular link in the network is present whether a the self-referenced node is moving, or another node is moving. If there is no circular link (node 3 to itself) then you're not getting the right files.

I recreated the problem with the example from #2591... something else must be amiss.

[eymiha]

Got it - for some reason node.shape.width is NaN, not undefined, going into _getCircleData, and then _resizeShape. Adding the checks into the pull request.

[Tooa]

Great it works now. However, I wonder why the width is NaN instead of undefined. What has changed that requires this additional change?

[Tooa]

Thank you. It still works fine and is a far better solution too.