Fix axis not displayed after daylight saving #2290
Conversation
|
Looks like a good solution to me. I'd personally prefer to have 2 o clock twice over an empty space but that's not for me to decide. |
| // correct for daylight saving | ||
| // FIXME: use this.current.add(moment.duration(this.step, 'hour')) | ||
| // see http://momentjs.com/docs/#special-considerations-for-months-and-years | ||
| if (this.current.hours() % this.step !== 0) { |
There was a problem hiding this comment.
To be honest, I don't understand this part. Can you explain in a few words what you are doing here?
There was a problem hiding this comment.
At this line:
this.current.add(this.moment.duration(this.step, 'hour'));we add for example 4 hours when this.step is 4. The resulting number of hours this.current.hours() should be a multiple of for, ie. the modulus of 4 should be zero.
What happens when stepping over daylight saving is that this.current.hours() becomes 3 instead of 4. Therefore we add the difference to the expected value 4, ie. 4-3 = add 1 hour.
Again, I would love to see this taken care of by moment.js since these are tricky things but I couldn't get that working quickly.
@mojoaxel can you have a look at this PR?
It fixes #2251.
It's a bit of a workaround, it should be able to solve this by using moment.duration (see moment.js docs: http://momentjs.com/docs/#special-considerations-for-months-and-years), but I couldn't get that working so far.
With this fix, the axis will be displayed again after daylight saving switch:
What's not yet very nice is that the hour 2 o clock is displayed twice (empty space would be more neat I think):