Moved recurring code for StepNumber to start() method

[wimrijnders]

The following code fragment:

step.start();
  if (step.getCurrent() < this.valueMin) {
    step.next();
}

Occurs every single time a StepNumber instance is used. This leads me to conclude that it should be part of the start() method. I've made its running optional, default is the original working.

[yotamberk]

Does this._start refer each time to the correct this.<coordinate>Min?

[wimrijnders]

Yes. If you follow the logic in the StepNumber c'tor:

• this.setRange() is called
• in setRange():

  this._start = start ? start : 0;

The only ways that the new value will not be set are:

• if it's zero, but that is the default anyway
• if it's undefined or null, but then the range is invalid
• if it's perhaps a boolean or another non-numeric type, in which case it had no business being passed.

[wimrijnders]

...so unless the passed start value for some reason changes between the initialization of the StepNumber instance and the call to start() (which is not the case in the code), we are good.