Hide vertically hidden ranged items in groups that are not visible #2062

yotamberk · 2016-09-02T22:10:42Z

No description provided.

mojoaxel · 2016-09-04T08:34:49Z

I would like to test this. Is there an issue this PR fixes? Which example can I use to see the changes?

mojoaxel · 2016-09-04T09:07:32Z

lib/timeline/component/item/RangeItem.js

@@ -43,8 +43,14 @@ RangeItem.prototype.baseClassName = 'vis-item vis-range';
 */
 RangeItem.prototype.isVisible = function(range) {
  // determine visibility
-  return (this.data.start < range.end) && (this.data.end > range.start);
-};
+var isVisible = 


The code formatting is broken here. Please check the indent of this function.

I've fixed it

yotamberk · 2016-09-04T12:30:01Z

Hey 😊
I'll fix the problem that was caused by my changes and fix what you commented on.
I have an example but it is not simple just by looking at the timeline. You'll need to follow an item as it disappears from view of the timeline window. I'll add an example.

Have a good day!
Yotam

נשלח מה-iPhone שלי

‫ב-4 בספט׳ 2016, בשעה 11:34, ‏‏Alexander Wunschik ‏[email protected] כתב/ה:‬

@yotamberk Thanks!

I would like to test this. Is there an issue this PR fixes? Which example can I use to see the changes?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

…into vertical-visibility

mojoaxel · 2016-09-05T11:15:59Z

examples/timeline/groups/verticalItemsHide.html

+  timeline.setGroups(groups);
+  timeline.setItems(items);
+
+// $(document).ready(function(){


What about all this comments. Can you remove them?

Sure, will do

נשלח מה-iPhone שלי

‫ב-5 בספט׳ 2016, בשעה 14:16, ‏‏Alexander Wunschik ‏[email protected] כתב/ה:‬

In examples/timeline/groups/verticalItemsHide.html:

editable: true,

margin: {

item: 10, // minimal margin between items

axis: 5 // minimal margin between items and the axis

},

orientation: 'top'

};

// create a Timeline

var container = document.getElementById('mytimeline');

timeline = new vis.Timeline(container, null, options);

timeline.setGroups(groups);

timeline.setItems(items);

+// $(document).ready(function(){
What about all this comments. Can you remove them?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

yotamberk · 2016-09-09T21:05:40Z

Hey, I've fixed the code so all examples work again.
This MR allows hiding vertically any range items in groups that are not in the visible window of the timeline.
Hiding of all the other types of items will be submitted in another MR.

mojoaxel · 2016-09-09T21:48:16Z

Thanks. I'll check and merge it in the next days.

yotamberk · 2016-09-09T22:37:01Z

Great! Thanks!

On Sat, Sep 10, 2016 at 12:48 AM, Alexander Wunschik <
[email protected]> wrote:

Thanks. I'll check and merge it in the next days.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2062 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEHquEOPDeQsTT_5kmTk2nt1UP7SbJvGks5qodQogaJpZM4J0IGh
.

mojoaxel · 2016-09-12T08:13:25Z

The files in the dist folder should not be changed. :-|
Can you please reset them:

git reset HEAD~1 dist
git commit --amend --no-edit

…roups

yotamberk · 2016-09-12T18:58:30Z

Done. Sorry for that...

mojoaxel · 2016-09-13T14:16:11Z

I tested a few examples. Looks good!

mojoaxel · 2016-09-13T22:56:18Z

@yotamberk Thanks again also for your patience!

yotamberk · 2016-09-14T05:04:56Z

Ofcourse. I'm working on some other features and bug fixes. Going through
TODOs and trying to understand what is plausible. Hope to have a scroll bar
option for timeline by next week

בתאריך 14 בספט׳ 2016 1:56 לפנה״צ,‏ "Alexander Wunschik" <
[email protected]> כתב:

@yotamberk https://github.com/yotamberk Thanks again also for your
patience!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2062 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEHquHZb_PFeL5D6ZbKTugKJ96_e25Ksks5qpyoZgaJpZM4J0IGh
.

mojoaxel · 2016-09-14T12:03:13Z

I'm working on some other features and bug fixes.

@yotamberk 👍

yotamberk added 2 commits September 3, 2016 01:08

Hide vertically hidden ranged items in groups that are not visible

f1cb732

Fix misspelling

f096f27

mojoaxel added the Timeline label Sep 4, 2016

mojoaxel reviewed Sep 4, 2016
View reviewed changes

mojoaxel added the waiting for answer/improvement label Sep 4, 2016

mojoaxel added this to the v4.17 milestone Sep 4, 2016

yotamberk added 4 commits September 4, 2016 23:37

Fix examples that do not contain groups

bcb1789

Merge branch 'vertical-visibility' of https://github.com/yotamberk/vis …

666a221

…into vertical-visibility

Add example for vertical hidden ranged items

1bd62d4

Fix indent format in RangeItem

e9bc845

mojoaxel added Feature-Request and removed waiting for answer/improvement labels Sep 5, 2016

mojoaxel reviewed Sep 5, 2016
View reviewed changes

Fix example

204ddb0

Fix other examples after addition of vertical hiding range items in g…

59d98c7

…roups

yotamberk force-pushed the vertical-visibility branch from 1ee2849 to 59d98c7 Compare September 12, 2016 18:52

Add case of zero margin axis

cb55268

mojoaxel merged commit 0ba6e16 into visjs:develop Sep 13, 2016

yotamberk deleted the vertical-visibility branch September 13, 2016 16:31

yotamberk mentioned this pull request Oct 17, 2016

Get group Ids displayed in Timeline #717

Closed

mojoaxel mentioned this pull request Nov 9, 2016

Timeline jittering when updating group heights in 4.17.0 #2287

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hide vertically hidden ranged items in groups that are not visible #2062

Hide vertically hidden ranged items in groups that are not visible #2062

Uh oh!

yotamberk commented Sep 2, 2016

Uh oh!

mojoaxel commented Sep 4, 2016

Uh oh!

mojoaxel Sep 4, 2016

Uh oh!

yotamberk Sep 4, 2016

Uh oh!

yotamberk commented Sep 4, 2016

Uh oh!

mojoaxel Sep 5, 2016

Uh oh!

yotamberk Sep 5, 2016

Uh oh!

yotamberk commented Sep 9, 2016

Uh oh!

mojoaxel commented Sep 9, 2016

Uh oh!

yotamberk commented Sep 9, 2016

Uh oh!

mojoaxel commented Sep 12, 2016 •

edited

Loading

Uh oh!

yotamberk commented Sep 12, 2016

Uh oh!

mojoaxel commented Sep 13, 2016

Uh oh!

mojoaxel commented Sep 13, 2016

Uh oh!

yotamberk commented Sep 14, 2016

Uh oh!

mojoaxel commented Sep 14, 2016

Uh oh!

Uh oh!

Hide vertically hidden ranged items in groups that are not visible #2062

Hide vertically hidden ranged items in groups that are not visible #2062

Uh oh!

Conversation

yotamberk commented Sep 2, 2016

Uh oh!

mojoaxel commented Sep 4, 2016

Uh oh!

mojoaxel Sep 4, 2016

Choose a reason for hiding this comment

Uh oh!

yotamberk Sep 4, 2016

Choose a reason for hiding this comment

Uh oh!

yotamberk commented Sep 4, 2016

Uh oh!

mojoaxel Sep 5, 2016

Choose a reason for hiding this comment

Uh oh!

yotamberk Sep 5, 2016

Choose a reason for hiding this comment

Uh oh!

yotamberk commented Sep 9, 2016

Uh oh!

mojoaxel commented Sep 9, 2016

Uh oh!

yotamberk commented Sep 9, 2016

Uh oh!

mojoaxel commented Sep 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yotamberk commented Sep 12, 2016

Uh oh!

mojoaxel commented Sep 13, 2016

Uh oh!

mojoaxel commented Sep 13, 2016

Uh oh!

yotamberk commented Sep 14, 2016

Uh oh!

mojoaxel commented Sep 14, 2016

Uh oh!

Uh oh!

mojoaxel commented Sep 12, 2016 •

edited

Loading