This repository was archived by the owner on Jul 29, 2019. It is now read-only.
make bundleing with webpack possible #1967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this "fixes" #1866 |
yotamberk
approved these changes
Oct 11, 2016
|
Hi @mojoaxel, |
done. |
|
It seems to be working fine! |
|
Yeah!! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the following dependencies from
devDependenciestodependencies:I use the timeline component in a project. If I include
dist/vis-timeline-graph2d.min.jsi have the problem thatmomentandhammerjsare included twice.So the best way ist to include
/vis-timeline-graph2d.jswith webpacks babel-loader and let the module-bundler figure out the rest. So I don't want to build my owndistversion, but want to resolve the dependencies "on the fly". This is also recessary for things like tree shaking and other fancy stuff.The only think that has to be changed for that ist to install the needed dependencies together with vis itself. Voila!
I tried it and it works with webpack. The vis code now is only half the size!