This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Timestep setMoment fix #1932
Merged
Timestep setMoment fix #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
In TimeStep's setMoment function, the TimeStep accepts a new
momentinstance, and then uses it to clone new values for itscurrent,_start, and_endvalues. The problem is that if the new moment instance has a different locale, these values do not get the new locale since they were cloned from the old instances.Changes
The fix is to instead pass the new moment instance the date values of the variables. This will create new moment instances for the variables that have the new locale.
Note: this bug won't be apparent in examples that set window's moment, as this is the instance originally required by the TimeStep, so locale changes would, in that case, be reflected.