Fixed getPoint for same node edges

[aanm]

If an edge was point out to the same node, the getPoint returns the wrong coordinates.

Signed-off-by: André Martins [email protected]

[mojoaxel]

@aanm It looks good but I can't figure out an simple example to test the changed getPoint function. Can you provide some code for testing this issue?

[aanm]

@mojoaxel Sure, can you please tell me where do you want me to put the test? Do you want it here or in a file under vis/test? If a file under vis/test which one?
Thanks

[mojoaxel]

@aanm Most people create a jsbin or jsfiddle. If it's an short example just just post it here.

The code looks good but I want to test it before I merge it. What settings are needed that this function is executed? That's why I need an example.

[aanm]

@mojoaxel oh okay. so the problem is simple, I was following this thread #507 and when I used the code provided by @edvineshagh I saw that it didn't work for edges that were pointed to the same node. That's why I figure out the getPoints function had a bug for the edges that were pointed out to the same node. Can you test based on this?

[mojoaxel]

Today I found the time to look into this again. I still don't get it. 😞

I tried to create an example with a node having an edge from and to itself. Also enabled default dynamic smoothing and arrows. As far as I can see the getPoint is never called on edges that have the same from and to. I can' test this.

@aanm Please provide a simple example that shows a use case for this pull request. Thx!

[aanm]

@mojoaxel There you go https://jsfiddle.net/2xc5r20j/ :-)
Like I said, the thread #507 is the one that calls the getPoint function. The animation code is a little buggy but the gist is there.
sorry I was planing on provide an example but I hadn't time to create it.

[yotamberk]

@mojoaxel What's the status on this PR?

[mojoaxel]

What's the status on this PR?

The code looks good but I hab problems creating an example to debug the changes. I think we can merge it, but I would feel better if I actually understood when this is needed.

[mojoaxel]

Shi**. This should not go into the master branch...I'll revert this.

[mojoaxel]

@aanm Sorry, but I had to revert the changes because they were made to the master branch. If you still want them to be added please create a new PR to the develop branch. Thx.

[aanm]

@mojoaxel this way? #2161