[Timeline] [dev branch] Major axis labels displaying wrong value

[lewisjb]

This is on the dev branch so I don't have a JSBin, but I do have screenshots.

The below screenshots are for http://visjs.org/examples/timeline/groups/groups.html

This is what it looks like on the website:

And this is what it looks like locally from dev:

Note the major axis (the bottom-left text "January 2017" and "00:00:00")

I did some digging and found that the issue stems from this commit: 9f0376e
Reverting the second change (the one for _repaintMajorText), makes the major axis act the same as it used to.

@yotamberk, since this is your commit, would you know a nice fix for this?

[yotamberk]

@lewisjb Ummm I must admit I have no idea why this is happening... The commit shouldn't have affected this... I'll have to get in to it. Not sure yet how to approach this...

[lewisjb]

@yotamberk I had another look into it and found the issue.

You changed document.createTextNode(text); to var content = document.createElement('div'); (and then set the innerHTML), but outside that if-statement, you are trying to set the value of that div via label.childNodes[0].nodeValue; but, childNodes[0] is content, not the text node inside content. So any changes to the content of major axis doesn't work, they keep the value they were given when they were created.

So it can be fixed by changing it to label.childNodes[0].childNodes[0].nodeValue, but I think label.childNodes[0].innerHTML would be cleaner (as it is how the text is originally set, and how the text is set for minor axis). And at the same time, line 367 content.innerHTML = text, can be removed; as the text is being set a few lines down anyway.

[mojoaxel]

Fixed by @yotamberk with #2551