Refactor: Group mp4 and heic with other offset-based types #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the `mp4` and `heic` cases in the `get` method to group them with other file types that use an `offset` match type. This change improves code readability and organization without altering functionality.
Moves `FileMagicNumberType.mp4` and `FileMagicNumberType.heic` to use the `byRange` matching strategy instead of `exact`. This change groups them with other formats like `webp`, `wav`, and `avi` that already use range-based magic number matching.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 47 45 -2
=========================================
- Hits 47 45 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a new test to verify that `detectFileTypeFromBytes` correctly identifies a file type based on its initial magic number, even when it contains another file type embedded within it. Specifically, the test uses a byte slice representing a PDF that contains a JP2 file signature and confirms that it is correctly detected as a PDF.
Adds a new test to verify that `detectFileTypeFromBytes` correctly identifies a file type based on its initial magic number, even when it contains another file type embedded within it. Specifically, the test uses a byte slice representing a PDF that contains a JP2 file signature and confirms that it is correctly detected as a PDF.
Bumps the version to 1.4.1. This patch addresses an issue where a PDF file containing a JPEG 2000 (JP2) image was incorrectly identified as a JP2 file. Changes include: - Corrected the file type detection logic to properly distinguish between a standalone JP2 file and a PDF embedding a JP2. - Added a new test case to verify the fix and prevent future regressions for PDFs that contain other file types.
Adds the issue number to the changelog entry for version 1.4.1, referencing the fix for an issue where a PDF containing a JP2 image was incorrectly identified as a JP2 file.
vicajilau
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
heiccases in thegetmethod to group them with other file types that use anoffsetmatch type. This change improves code readability and organization without altering functionality.ISSUE: #27