Skip to content

Conversation

aef-
Copy link
Contributor

@aef- aef- commented Apr 12, 2023

This is essentially #37 with additional updates and commit history from Basho's version. I'm happy to reconcile changes between this and #37 if we're able to get #37 merged in.

Martin Cox and others added 30 commits April 4, 2019 21:43
relx start scripts through the use of relx start script hooks.
unbashify & symlink sys.config too
…bundled start script. We need to generate these when using the relx scripts as the vanilla script checks that vm_args exists.
with -o or --output-dir. Without this, cuttlefish tries to create the
default conf based upon the base_dir/rel, which breaks.
Need to control lager version
So avoid new to grant write access to platform_etc_dir
Only without start script
Wnat to link generated file, to file in standard location - so that the relx script can be primed to look for this standard file
Note dialyzer does not pass - but accepted as plugin
@ioolkos
Copy link
Contributor

ioolkos commented Apr 12, 2023

@aef- Thanks! I'm not against merging history in. (but have not yet looked at the commits)
It absolutely must not break the VerneMQ release builds, though! 😄 As an example, Verne does currently not use the extended_bin_script.

@aef-
Copy link
Contributor Author

aef- commented Apr 12, 2023

Thanks ioolkos, I gotcha! I diff'd the generated bin scripts with both versions and there isn't a difference. This is because you all are using template overlay without generate_start_script. I think, then, line 97 is the only difference, as the rest are essentially behind flags that are disabled by default so they should not affect your output. Let me know, I'll make w/e changes necessary to get this merged in.

@ioolkos
Copy link
Contributor

ioolkos commented Apr 13, 2023

@aef- Thanks. I just run a local build test for Verne, with your rebar3_cuttlefish PR in a _checkouts dir, so that the plugin is taken locally from there. Seems it does not break nodetool/vernemq/vmq-admin scripts, so looks good so far.

@aef- aef- mentioned this pull request Apr 14, 2023
4 tasks
@ioolkos
Copy link
Contributor

ioolkos commented Apr 17, 2023

@aef- I'm merging this, somewhat guerilla style. It doesn't seem to break Verne builds but my thinking is that the merge will surface any issues with that rather quickly, in any case.

@ioolkos ioolkos merged commit 53b4602 into vernemq:master Apr 17, 2023
@aef-
Copy link
Contributor Author

aef- commented Apr 17, 2023

Sounds good @ioolkos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants