fix: ENAMETOOLONG error by ETag handling in image optimizer #85978 #86102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the base64url encoding of the upstream ETag with getHash function to create a short, filesystem-safe identifier.
What & Why?
If the upstream server sends a very long ETag, the encoded string becomes very long. The full file path exceeded the OS filename length limit (~255 characters). Then Node throws, ENAMETOOLONG.
How?
changed upstream ETag processing from:
Buffer.from(etag).toString('base64url')to,getHash([etag]). This transforms, the ETag string into one fixed-size SHA-256 hash.Fixes #85978