Allow reading request bodies in middlewares #34294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kodiakhq merged 7 commits into vercel:canary from Schniz:read-json-body

Feb 17, 2022

Contributor

Schniz commented Feb 13, 2022 •

edited

Loading

Related:

resolves Middleware in API have a null body on POST Requests #30953

ijjk added the type: next label

Schniz commented

View reviewed changes

packages/next/package.json Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Schniz force-pushed the read-json-body branch from 2632070 to 05edc74 Compare

February 14, 2022 13:13

Schniz marked this pull request as ready for review

February 14, 2022 13:14

Schniz requested review from huozhi, ijjk, shuding and timneutkens as code owners

February 14, 2022 13:14

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Schniz force-pushed the read-json-body branch from f3b61f3 to 0a841a5 Compare

February 14, 2022 14:08

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Schniz force-pushed the read-json-body branch from 5cd2ba2 to 04177b8 Compare

February 14, 2022 16:01

This comment has been minimized.

Sign in to view

Member

ijjk commented Feb 14, 2022

Failing test suites

Commit: 04177b8

yarn testheadless test/integration/ondemand/test/index.test.js

On Demand Entries > should navigate to pages with dynamic imports

Expand output

● On Demand Entries › should navigate to pages with dynamic imports

TIMED OUT: /Hello/

/nav/dynamic

  474 |
  475 |   if (hardError) {
> 476 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  477 |   }
  478 |   return false
  479 | }

  at Object.check (lib/next-test-utils.js:476:11)
  at Object.<anonymous> (integration/ondemand/test/index.test.js:128:7)

Read more about building and testing Next.js in contributing.md.

ijjk reviewed

View reviewed changes

test/production/reading-request-body-in-middleware/index.test.ts

    
                beforeAll(async () => {

                  next = await createNext({

                    files: {

                      'pages/_middleware.js': `

Member

ijjk Feb 14, 2022

Can we add a test case where the middleware reads the body but then continues to an API route that returns the body from req.body?

Contributor Author

Schniz Feb 15, 2022

good idea

Contributor Author

Schniz Feb 15, 2022

Schniz marked this pull request as draft

February 15, 2022 11:13

This comment has been minimized.

Sign in to view

Schniz force-pushed the read-json-body branch from 5f3a55d to a3be56d Compare

February 15, 2022 15:07

This comment has been minimized.

Sign in to view

Schniz commented

View reviewed changes

packages/next/server/next-server.ts Outdated Show resolved Hide resolved

Schniz marked this pull request as ready for review

February 15, 2022 16:22

Schniz requested a review from ijjk

February 15, 2022 16:22

This comment has been minimized.

Sign in to view

ijjk requested a review from javivelasco

February 15, 2022 19:14

This was referenced Feb 19, 2022

[Snyk] Security upgrade next from 10.2.3 to 12.1.0 adamlaska/next.js#124

Open

[Snyk] Security upgrade next from 10.2.3 to 12.1.0 adamlaska/next.js#125

Open

[Snyk] Security upgrade next from 10.2.0 to 12.1.0 adamlaska/next.js#126

Open

[Snyk] Security upgrade next from 10.0.4 to 12.1.0 adamlaska/next.js#127

Open

[Snyk] Security upgrade next from 10.0.9 to 12.1.0 adamlaska/next.js#129

Open

[Snyk] Security upgrade next from 10.0.8 to 12.1.0 adamlaska/next.js#130

Open

[Snyk] Security upgrade next from 10.1.3 to 12.1.0 adamlaska/next.js#131

Open

[Snyk] Security upgrade next from 10.0.3 to 12.1.0 adamlaska/next.js#132

Open

[Snyk] Security upgrade next from 10.0.7 to 12.1.0 adamlaska/next.js#133

Open

[Snyk] Security upgrade next from 10.2.3 to 12.1.0 adamlaska/next.js#134

Open

[Snyk] Security upgrade next from 10.0.3 to 12.1.0 adamlaska/next.js#135

Open

[Snyk] Security upgrade next from 10.0.3 to 12.1.0 donavon/next.js#113

Open

[Snyk] Security upgrade next from 10.2.3 to 12.1.0 donavon/next.js#114

Open

[Snyk] Security upgrade next from 10.0.7 to 12.1.0 majacQ/next.js#325

Merged

[Snyk] Security upgrade next from 10.2.3 to 12.1.0 majacQ/next.js#326

Merged

[Snyk] Security upgrade next from 10.0.3 to 12.1.0 majacQ/next.js#327

Merged

This was referenced Feb 28, 2022

[Snyk] Security upgrade next from 10.2.3 to 12.1.0 Mement-Mori/next.js#211

Open

[Snyk] Security upgrade next from 10.2.0 to 12.1.0 Mement-Mori/next.js#212

Open

[Snyk] Security upgrade next from 10.0.4 to 12.1.0 Mement-Mori/next.js#213

Open

[Snyk] Security upgrade next from 10.0.8 to 12.1.0 Mement-Mori/next.js#219

Open

[Snyk] Security upgrade next from 11.1.4 to 12.1.0 MaxMood96/next.js#261

Open

[Snyk] Security upgrade next from 10.0.3 to 12.1.0 MaxMood96/next.js#262

Open

[Snyk] Security upgrade next from 11.1.0 to 12.1.0 MaxMood96/next.js#263

Open

[Snyk] Security upgrade next from 10.0.7 to 12.1.0 MaxMood96/next.js#264

Open

[Snyk] Security upgrade next from 10.0.3 to 12.1.0 Mement-Mori/next.js#220

Open

[Snyk] Security upgrade next from 10.2.3 to 12.1.0 MaxMood96/next.js#266

Open

[Snyk] Security upgrade next from 10.1.3 to 12.1.0 MaxMood96/next.js#269

Open

[Snyk] Security upgrade next from 10.0.4 to 12.1.0 MaxMood96/next.js#270

Open

pettinarip mentioned this pull request

Captcha in forms ethereum/esp-website#204

Merged

5 tasks

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels