Skip to content

Throw Error when url.parse without true is parsed #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 1, 2017
Merged

Throw Error when url.parse without true is parsed #1282

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
060b159
Throw Error when url.parse without true is parsed
timweprovide Feb 25, 2017
80bdfa2
Parse when needed
timweprovide Feb 26, 2017
a694294
Merge branch 'master' of git://github.com/zeit/next.js into improve-p…
timweprovide Feb 26, 2017
d771e82
Merge branch 'master' of git://github.com/zeit/next.js into improve-p…
timweprovide Feb 28, 2017
0202a40
Parse querystring if it is not provided
timweprovide Feb 28, 2017
256324e
Merge branch 'master' of git://github.com/zeit/next.js into improve-p…
timweprovide Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,10 @@ export default class Server {

getRequestHandler () {
return (req, res, parsedUrl) => {
if (!parsedUrl) {
if (!parsedUrl || parsedUrl && !parsedUrl.query) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this simplifies to if (!parsedUrl || !parsedUrl.query)

Copy link
Member Author

@timneutkens timneutkens Feb 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sedubois since it's an or both sides of the expression are executed. In this case when parsedUrl is undefined it will throw an query is not defined error. That's why we have to check if parsedUrl exists 👍 If this was && you would be totally right 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sorry I meant this should probably work: if (!(parsedUrl && parsedUrl.query)). But anyways not super important...

parsedUrl = parse(req.url, true)
}

if (!parsedUrl.query) {
throw new Error('Please provide a parsed url to `handle` as third parameter. See https://github.com/zeit/next.js#custom-server-and-routing for an example.')
}

return this.run(req, res, parsedUrl)
.catch((err) => {
if (!this.quiet) console.error(err)
Expand Down