fix(openai): treat unknown models as reasoning #9976
Merged
+84
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
openai-reasoning-defaults
branch
from
f714fdc to
8c60210
Compare
gr2m
commented
Nov 3, 2025
| ['gpt-5-nano-2025-08-07', 'true'], | ||
| ['gpt-5-pro', 'true'], | ||
| ['gpt-5-pro-2025-10-06', 'true'], | ||
| ['new-unknown-model', 'true'], |
There was a problem hiding this comment.
I will shorten the list before merging, just wanted to keep it complete for review
lgrammel
approved these changes
Nov 3, 2025
|
i like this solution |
|
it changes the defaults for unknown models, so it might be a breaking change for folks who use the openai provider with a different baseurl and provider (instead of openaicompat) for historical reasons. might be good to keep ai sdk 6 only and mention in the migration guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Most new models coming from OpenAI are reasoning now
Summary
If a model is not recognized, it is now treated as a reasoning model.
I also refactored the code so that responses and chat models are sharing the same logic.
Manual Verification
tested with
openaiexamplesChecklist
pnpm changesetin the project root)Future Work
Look into adding a flag to manually set if a model is treated as reasoning.
Related Issues