Skip to content

Fix time accumolation #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChrJohansen merged 3 commits into from
Aug 28, 2025
Merged

Fix time accumolation #52

ChrJohansen merged 3 commits into from
Aug 28, 2025

Conversation

@ChrJohansen
Copy link
Collaborator

@ChrJohansen ChrJohansen commented Aug 27, 2025 •
edited
Loading

WHAT

Use the TotalHours property of the TimeSpan , not Hours

WHY

Bugfix - The challenge stats for time challenges was wrong

HOW

  1. Checkout this branch and run it
  2. Create a time challenge
  3. Add enough activities such that the time elapsed for an athlete becomes more than 24 hours
  4. Verify that the stats does NOT circle the 24 hour interval

veloek
veloek approved these changes Aug 27, 2025
View reviewed changes
Copy link
Owner

@veloek veloek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ChrJohansen ChrJohansen merged commit 842273d into main Aug 28, 2025
@ChrJohansen ChrJohansen deleted the fix-time-accumolation branch August 28, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veloek veloek veloek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrJohansen @veloek