Skip to content

Conversation

@thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Oct 31, 2025

Summary

Since ~/.cargo/bin was being pulled in from cargo-cache then vdev was already present making the vdev cargo install fail because a previous version was already present.

This also adds the cache-prepare-binaries to maintain behavior with the caching of ~/.cargo/bin.

Vector configuration

NA

How did you test this PR?

Added pull_request to changes.yml which downloads cached vdev in commit 55a675c. Let CI run and verified that vdev was cached and not rebuilt and that vdev int build ran and didn't error with command not found. Commit reverted afterwards.

See run

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Oct 31, 2025
thomasqueirozb

This comment was marked as outdated.

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 31, 2025
@thomasqueirozb thomasqueirozb marked this pull request as ready for review October 31, 2025 19:25
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner October 31, 2025 19:25
@pront pront added this pull request to the merge queue Nov 1, 2025
@pront pront removed this pull request from the merge queue due to a manual request Nov 1, 2025
@pront pront added this pull request to the merge queue Nov 3, 2025
Merged via the queue into master with commit 5cf227e Nov 3, 2025
45 checks passed
@pront pront deleted the fix-vdev-caching branch November 3, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants