-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(unit tests): respect color flag for tests #23957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @VanjaRo
Head branch was pushed to by a user without write access
Sry, I accidentally pushed the wrong class name for multiple Diagnostics. Fixed. |
Did you have a chance to repeat the tests with the latest version? |
Yep, tests and check –– same output as master. |
Head branch was pushed to by a user without write access
6a8dccc
Summary
vector test
now disables ANSI color when non-interactive (e.g., CI), preventing escape codes in logs.Vector configuration
How did you test this PR?
--color auto
shows ANSI when run in an interactive terminal, and no ANSI when piped/redirected.--color always|never
andVECTOR_COLOR=always|never
.validate
, conditions (src/conditions/vrl.rs
),remap
transform, HTTP server auth, and HTTP client query parameters show colored output only when enabled.init_logging
and downstream modules receive the same global color preference viaset_global_color(...)
.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changelog
label to this PR.References