Skip to content

Conversation

titaneric
Copy link
Contributor

@titaneric titaneric commented Oct 3, 2025

Summary

This PR intends to add the document to describe new VRL function introduced in vectordotdev/vrl#1531, vectordotdev/vrl#1532, vectordotdev/vrl#1533

Vector configuration

How did you test this PR?

cue lint

./website/scripts/cue.sh fmt
CI=true make check-docs

document preview

make preview-build
make serve

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Closes: vectordotdev/vrl#1348

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@titaneric titaneric requested review from a team as code owners October 3, 2025 07:14
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Oct 3, 2025
@titaneric titaneric changed the title docs(vrl): add path related documents docs(vrl): add new path related documents Oct 3, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look reasonable. Worth mentioning that this platform dependent (based on the discussion in one of the PRs).

Let's also wait for a review from @vectordotdev/documentation

@pront pront added this to the 0.51.0 milestone Oct 6, 2025
@maycmlee maycmlee self-assigned this Oct 6, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 6, 2025
@pront pront enabled auto-merge October 6, 2025 16:15
@pront pront added this pull request to the merge queue Oct 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 6, 2025
@pront
Copy link
Member

pront commented Oct 6, 2025

@maycmlee maycmlee removed their assignment Oct 6, 2025
@titaneric
Copy link
Contributor Author

titaneric commented Oct 6, 2025

cargo vdev check docs
Validating cue files formatting...
/home/runner/work/vector/vector/scripts/check-docs.sh: line 17: /home/runner/work/vector/vector/website/scripts/cue.sh: No such file or directory
Error: command: cd "/home/runner/work/vector/vector" && "/home/runner/work/vector/vector/scripts/check-docs.sh"
failed with exit code: 127

It seems that the cue.sh script is missing on the runner. The cue.sh is located in scripts not in website/scripts

@pront
Copy link
Member

pront commented Oct 6, 2025

cargo vdev check docs
Validating cue files formatting...
/home/runner/work/vector/vector/scripts/check-docs.sh: line 17: /home/runner/work/vector/vector/website/scripts/cue.sh: No such file or directory
Error: command: cd "/home/runner/work/vector/vector" && "/home/runner/work/vector/vector/scripts/check-docs.sh"
failed with exit code: 127

It seems that the cue.sh script is missing on the runner. The cue.sh is located in scripts not in website/scripts

Hi @titaneric, this is a regression from #23951. We will fix this. Thanks.

@pront pront added this pull request to the merge queue Oct 6, 2025
Merged via the queue into vectordotdev:master with commit 59689d3 Oct 6, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] path functions dirname and basename

4 participants